geosolutions-it / jai-ext

Java Advanced Imaging Open Source Replacement Wannabe
Apache License 2.0
90 stars 38 forks source link

ROI derived weights are thrown away before interpolation #202

Closed aaime closed 5 years ago

aaime commented 6 years ago

In the bilinear and bicubic interpolators the ROI derived weights are simply reset to one after using them to check if the pixels are within ROI, resulting in pixels outside of the ROI participating the output and consequent generation of dark pixels around the ROI borders.

Non exaustive examples:

All examples are basically throwing away ROI info and just considering nodata instead, but the actual weights should be a combination of the two instead.

We should find all places where this is happening and fix accordingly (and then write tests, oh fun).