search

geosolutions-it / jai-ext

Java Advanced Imaging Open Source Replacement Wannabe
Apache License 2.0
89 stars 38 forks source link

Upgrade to JTS 1.17.0 #269

Closed jnh5y closed 4 years ago

jnh5y commented 4 years ago

Signed-off-by: Jim Hughes jnh5y@ccri.com

aaime commented 4 years ago

Looks good I guess? Is everything building fine downstreams? If so, we can do a release.

jnh5y commented 4 years ago

@aaime yes. An initially round of downstream builds worked for me (using mvn clean install).

Is there a better way for me to test the builds?

aaime commented 4 years ago

@jnh5y if you built geotools with "-Dall" and geoserver with "-Prelease" then we should be good. For extra credits, go into the geoserver community section and build with "-PcommunityRelease -DskipTests".

jnh5y commented 4 years ago

@aaime I'll try that locally here in a bit.

dromagnoli commented 4 years ago

@aaime I'll try that locally here in a bit.

@jnh5y Great! I'll start the release as soon as you are done with that.

jnh5y commented 4 years ago

@aaime @dromagnoli ok, running 'mvn clean install' on GT/GWC/GS did work for me. GT with 'mvn clean install -Dall' is showing that 'flatgeobuf' is going to need to be updated to the latest JTS.

I'll sort that out and verify that I can build GT with a snapshot of that project.

aaime commented 4 years ago

The profiles/params I've mentioned are the ones used by the build server, we should probably make them the defaults.

jnh5y commented 4 years ago

Ok, an as update, the PR here: https://github.com/bjornharrtell/flatgeobuf/pull/65 gets the full GT build to go. I'll ping Bjorn about that release.

jnh5y commented 4 years ago

@aaime @dromagnoli ok, I've managed to build GT/GWC/GS locally with full builds on JDK 8. That did turn needs for flatbufgeo and java-vector-tiles to be updated as well. I'm using https://github.com/geotools/geotools/pull/3034 to track progress overall.

I think this should be a green light for cutting the jai-ext upgrade and release. I'm seeing jai-ext do what the unit tests in GT/GWC/GS say it should!

dromagnoli commented 4 years ago

@jnh5y Merged. i'm going to do the release right now (I'll notice you when finished) You might need to update the version of jai-ext on GT/GS/GWC poms accordingly

dromagnoli commented 4 years ago

@jnh5y

Release done. https://maven.geo-solutions.it/it/geosolutions/jaiext/jaiext/1.1.16/jaiext-1.1.16.pom

jnh5y commented 4 years ago

@dromagnoli thanks! I've updated the PRs with this version. I'm rebuilding locally to double-check things. I'll shout if there are any issues.