Fix set thumbnail map widget

geosolutions-it / nexus-geonode

Nexus Platform

BSD 2-Clause "Simplified" License

0 stars 4 forks source link

Fix set thumbnail map widget #555

Closed giohappy closed 2 years ago

giohappy commented 2 years ago

@allyoucanmap can you please provide indications to @DavidQuartz about the expected fixes? IIRC it was about replacing the current direct port of the wizard widget UI/UX

allyoucanmap commented 2 years ago

@DavidQuartz requirements:

change width and height to make aspect ratio consistent
rename save to apply and move to the top left
remove close and use the x icon with a button
remove the blu vector layer on top because is not needed
open the thumbnail map view to the current bbox/extent of the main map

please provide a quick screenshot for the new buttons position, thanks

DavidQuartz commented 2 years ago

@allyoucanmap @giohappy is this okay for the new buttons and positions?

Screenshot 2022-01-21 at 13 34 53

giohappy commented 2 years ago

to me it's ok. @allyoucanmap?

allyoucanmap commented 2 years ago

ok from me @DavidQuartz

allyoucanmap commented 2 years ago

https://user-images.githubusercontent.com/19175505/151014605-cda75645-4d61-49ab-a251-82808b0c8eea.mp4

@DavidQuartz just tested locally and the map always reset to the initial bbox. The expected behaviors:

switch to map thumbnail
thumbnail map center on the current view
user can pan/zoom in the thumbnail map
other changes on the global map should not effect the current open thumbnail map. only the initial bbox

I think we should use the ZoomTo component instead of fit bounds one https://github.com/GeoNode/geonode-mapstore-client/blob/master/geonode_mapstore_client/client/js/components/FiltersForm/FilterByExtent.jsx#L24-L58

DavidQuartz commented 2 years ago

@allyoucanmap I fixed it in a new PR

fixed fitbounds