QoS Module code review

[fernandor777]

QoS Module adds a section on WMS and WFS Admin pages, with metadata configuration.

Also creates rest endpoints at global level and workspace for both WMS and WFS:

• /rest/services/qos/wfs/settings
• /rest/services/qos/wfs/workspaces/{workspaceName}/settings
• /rest/services/qos/wms/settings
• /rest/services/qos/wms/workspaces/{workspaceName}/settings

QoS metadata can be configured at workspace level too.

QoS Module is located on community directory (name: qos)

Branch:

https://github.com/fernandor777/geoserver/tree/qos-getcap

[aaime]

Notes:

• Many files are missing copyright headers, they need them before the module can be donate
• SerialConsumer seems like a "serial killer", but I believe it's a SerializableConsumer yes? If so please rename
• The user interface looks alien compared to the rest of GeoServer. For example, the green borders, the fields with label on top instead of on the side, the rectangles within rectangles (the typical approach in GeoServer would be to have a pop up editor or a separate page). Not a big deal for a community module, if it ever graduates we'll revisit:

• I could not complete an editing session, even if it seemed like I filled all fields, kept on complining about lack of start and end.

Had some difficulties with other bits of the UI as well, but nothing major.

I've also build the module dependencies and then the module itself, got two test failures (again, not a problem for a community module, tests are disabled anyways, it just needs to compile):

Failed tests:   
testQosDisabled(org.geoserver.qos.web.QosWfsPanelTest): expected:<false> but was:<true>
testQosDisabled(org.geoserver.qos.web.QosWmsPanelTest): expected:<false> but was:<true>

[simboss]

@aaime we put together the GUI together I asked him to avoid having multiple popups which was the direction he was taking. I agree the blocks are a little too much, we might want to revisit in the future.

@fernandor777 fix all the other things, especially the tests.

[fernandor777]

Thanks for your review.

About Start and End time inputs, they require full time format+timezone as 21:00:00+03:00 to pass validation. Should I add a simple time converter from 12:00 to 12:00:00+00:00 formats since timezone is required?

[aaime]

In absence of documentation yes, an example is good. Also the error message should mention that the format is wrong, not state that the info is missing.