geosolutions-it / smb-portal

SaveMyByke portal
https://waffle.io/geosolutions-it/smb-portal
1 stars 3 forks source link

GetDomainValues endpoint for Geoserver's multidim extension #122

Closed giohappy closed 6 years ago

giohappy commented 6 years ago

This proposal is for the creation of a new GetDomainValues endpoint to the WMTS MultiDimensional extension.

The goal is to let a client request a (paged) list of sorted unique domain values lower / greater then a certain value.

Description

The request params mimic those implemented by the DescribeDomain endpoint. This will simplify the development and gives consistency to the API. The following request parameters should be implemented:

Sample requests

aaime commented 6 years ago

Agree with the proposal and we have an estimate, ready to work on it as soon as it gets prioritized (it's top of my ready column now, but not sure if it happened only because it's the last being created, or it was moved there on purpose)

simboss commented 6 years ago

@aaime remember to update the documentation in the GeoServer docs.

aaime commented 6 years ago

Is the direction gone? direction=up/down

aaime commented 6 years ago

Ah, we don't really need it because the domain filter directions tells us where to go

aaime commented 6 years ago

Ouff... turns out I cannot use open intervals (min/ or /max), as intervals are used in other parts of the protocol and are always inclusive of their extrema, while here we need to filter so that the extrema is excluded. The code building the intervals and filters is shared, and besides the syntax is the same as DescribeDomain, so it would be odd to have same syntax and different semantic.

Ooooh well... I guess I'll have to go back to using reference=value and direction=up/down. I hope this is not too much of an inconvenience client side?

aaime commented 6 years ago

After some discussion with Lorenzo, we'll do this:

giohappy commented 6 years ago

Agreed. It was the initial proposal for that reason :wink:

aaime commented 6 years ago

Sorry! :-p

aaime commented 6 years ago

So the code has been merged, docs here: http://docs.geoserver.org/latest/en/user/community/wmts-multidimensional/index.html#getdomainvalues

Should be on cloudsdi today (midday deploy hopefully). I did not build a UI to configure the max server side "limit" value yet, keeping some time aside for bug fixing and other feedback. If we get some left at the end adding the UI should be quick.