search

geospace-code / georinex

Python RINEX 2 / 3 NAV / OBS / sp3 reader & batch convert to HDF5 with C-like speed
MIT License
216 stars 89 forks source link

60 seconds #70

Closed labonocl closed 3 years ago

labonocl commented 3 years ago

Hi there,

One of the sp3 files for ESA's Swarm mission (ftp://swarm-diss.eo.esa.int/Level1b/Latest_baselines/GPSxNAV/, Satellite A, file for November 26th 2013) contains the following line:

When trying to read this line with load_sp3, the datetime library complains with the following error:

ValueError: second must be in 0..59

The error is of course correct (this one file alone contains this error 64 times), so I see two options here: 1) Put on my Don-Quijote-hat and try to convince ESA that this is an error and that they should debug their data product processing chain and reprocess the entire seven years of Swarm data; or 2) check for such errors in sp3dt, and fix them there.

Now, I know what I am going to do. So the real question becomes: would you be interested in pulling such a correction of wrong times into the georinex package, or is your position that whoever is responsible for producing sp3 files should take care of this issue, and it is not the responsibility of georinex to handle other people's mistake?

Cheers Lasse

scivision commented 3 years ago

I think this is something georinex should tolerate. There are all kinds of quirks in RINEX that are non standard compliant