search

geospace-code / h5fortran

Lightweight HDF5 polymorphic Fortran: h5write() h5read()
https://geospace-code.github.io/h5fortran
BSD 3-Clause "New" or "Revised" License
99 stars 23 forks source link

It may not be clear to the user that the test step also submits a report to CDash #10

Closed bast closed 3 years ago

bast commented 3 years ago

I was following the build instructions at https://github.com/geospace-code/h5fortran#build

These contain a test step (which is very good and worked for me) and the test step contains a CDash step which reports to a public dashboard. The latter is useful for the project and not a problem per se but I think it might be useful to add a note to the documentation (README.md). The general user may not be aware that some information from their computer is being sent to a public dashboard.

(working on https://github.com/openjournals/joss-reviews/issues/2842)

milancurcic commented 3 years ago

:+1: As a step further, I'd suggest allowing the user to disable sending the report, perhaps with -DCMAKE_NO_CDASH_REPORT=1 or similar.

scivision commented 3 years ago

Thanks, I removed that script from the user documentation and instead only use it for CI.

bast commented 3 years ago

Thank you!