search

geospace-code / matmap3d

Matlab 3D coordinate conversions for geospace ecef enu ECI
https://geospace-code.github.io/matmap3d/
BSD 2-Clause "Simplified" License
20 stars 8 forks source link

Unable to start pull request (nothing to compare)...? #1

Closed fPkX6F1nGTX closed 4 years ago

fPkX6F1nGTX commented 4 years ago

I forked the entire repo to https://github.com/brethvoice/matmap3d and made my edits there. It is literally only adding ",1" inside the three calls to nan in ecef2eci.m, lines 20-22, inclusive.

scivision commented 4 years ago

thanks !

scivision commented 4 years ago

I fixed it in a slightly different way and found another place with the same issue in https://github.com/geospace-code/matmap3d/commit/499b29782f0f4c7c2f0f6e1e9201556884de6a9b

fPkX6F1nGTX commented 4 years ago

@scivision your method was more intuitive and less fragile. Thanks for the help; next time how do I actually do a pull request, because I was unable to do so this time?

scivision commented 4 years ago

I don't know, it may have been a GitHub bug. I haven't had that issue before

fPkX6F1nGTX commented 4 years ago

My first foray into the world of pull requests, and it was an epic fail. Sorry for making you code it for me, @scivision.

scivision commented 4 years ago

Well it's quite typical that I edit a PR because often it reveals additional issues that I hadn't realized till then