search

geospace-code / pymap3d

pure-Python (Numpy optional) 3D coordinate conversions for geospace ecef enu eci
https://geospace-code.github.io/pymap3d
BSD 2-Clause "Simplified" License
391 stars 85 forks source link

Spherical-earth assumption in ecef2enuv computation should be made more explicit #95

Closed niwhsa9 closed 6 months ago

niwhsa9 commented 6 months ago

The computation of ecef2enuv assumes a spherical model rather than an ellipsoid in the transformation. This might lead to some confusion since the library otherwise uses ellipsoids. At a minimum I think a disclaimer should be added to the docstring that the computation is done in this way.

https://github.com/geospace-code/pymap3d/blob/0bb4350d45929ebff69047260f7934b30b5e9bae/src/pymap3d/ecef.py#L232

niwhsa9 commented 6 months ago

nevermind, I think I misunderstood. This clears things up https://gssc.esa.int/navipedia/index.php/Transformations_between_ECEF_and_ENU_coordinates