search

geospatial-jeff / aiocogeo

Asynchronous cogeotiff reader
MIT License
73 stars 10 forks source link

fix unprediction of cog files #114

Open daguirreg opened 3 years ago

daguirreg commented 3 years ago

Hi, thank you for this library that is being very useful to me but while using it, I found the following bug:

COG files that were compressed with prediction level 2 are being unpredicted incorrectly. The problem is that the decoder is being applied on the wrong axis.

Please find attached some images that show the problem: This is the obtained image when applying the decoder on axis=1 unprediction_error

Obtained image applying the decoder on axis=2 correct_prediction

Also, take a look to the test called "test_cog_read_with_prediction_level_2" which validates the obtained image using rasterio.

geospatial-jeff commented 3 years ago

@daguirreg This looks great, thanks for the PR! Would you mind running black against the code so CI passes?