search

geostyler / geostyler-demo

GeoStyler Demo App
https://geostyler.github.io/geostyler-demo/
BSD 2-Clause "Simplified" License
8 stars 12 forks source link

Code editor does not reflect filter #180

Closed chrismayer closed 2 years ago

chrismayer commented 3 years ago

Bug

Describe the bug Filter is not reflected in style shown in the code editor (SLD / GeoStyler style).

There seems an update issue with the attribute and the value field. Maybe related to this changeset.

image

To Reproduce Steps to reproduce the behavior:

  1. Open the demo at https://geostyler.github.io/geostyler-demo/
  2. Click on filter icon (blue pencil)
  3. Type something in the attribute field, e.g. fooooo
  4. See that the field is reset to the first characte
  5. In case you type ahead the attribute and the value is no more reflected in the style shown in the code editor

Expected behavior The attribute and the value field is no more reflected in the style shown in the code editor

Screenshots image

Desktop (please complete the following information):

KaiVolland commented 3 years ago

I think the tests are to unprecise: https://github.com/geostyler/geostyler/blob/83c3e08a4b727eb63ba586a5f20baed7cfa28a9a/src/Component/Filter/ComparisonFilter/ComparisonFilter.spec.tsx#L85-L95

They only check if the onFilterChange is called. Not if the value is right.