search

geostyler / geostyler-demo

GeoStyler Demo App
https://geostyler.github.io/geostyler-demo/
BSD 2-Clause "Simplified" License
8 stars 12 forks source link

CardLayout bugs #406

Open KaiVolland opened 2 years ago

KaiVolland commented 2 years ago

There are some bugs/questions with the CardLayout in the geostyler-demo:

  1. We should check the Select Toggle:

    • What is its purpose, and does it work as expected?
    • Would a checkbox be more appropriate?

  2. The Renderer does not work and sends post request to \undefined

  3. "Title" Field should be removed as there is not title in the geostyler-style

Maybe these bugs are more related to the components themeselves in the geostyler, so we may have to fix the issues there.

jansule commented 1 year ago

The Renderer does not work and sends post request to \undefined

Our Renderer does not have a default URL to send requests to. <Style /> sets a wmsBaseUrl property in the demo, which is not set on the <CardStyle />. See https://github.com/geostyler/geostyler-demo/blob/d67b0fdc2624ca4284901e36c424b7e58a5da0c6/src/App.tsx#L345. This will be solved once we make use of GeoStylerContext