search

geostyler / geostyler-mapbox-parser

GeoStyler-Style-Parser implementation for Mapbox
BSD 2-Clause "Simplified" License
13 stars 9 forks source link

Track sources #289

Closed jansule closed 10 months ago

jansule commented 10 months ago

This keeps track of the source and layer-source properties of a mapbox style layer. Through this, we are able to keep the references to sources and source-layers to/from rules when parsing multiple times. This also enables the assignment of geostyler rules to specific sources, which is needed when creating new styling instructions that were not yet present in a mapbox style.

BREAKING CHANGE: This makes the previously omitted source property of a mapbox style required. So we are actually conformant with the mapbox style specification in that regard. This breaking change probably affected mostly our tests, which were adjusted.

depends on https://github.com/geostyler/geostyler-mapbox-parser/pull/287

jansule commented 10 months ago

Thanks for the reviews. @KaiVolland could you take another look at the code? I just rebased against current master and applied some changes

dnlkoch commented 7 months ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: