geostyler / geostyler-mapbox-parser

GeoStyler-Style-Parser implementation for Mapbox
BSD 2-Clause "Simplified" License
14 stars 9 forks source link

[mapbox-parser] TextSymbolizer & IconSymbolizer undistinguishable #34

Closed KaiVolland closed 3 months ago

KaiVolland commented 5 years ago

PARSER

MAPBOX

QUESTION

Description:

Mapbox merges the attributes of TextSymbolizer and IconSymbolizer in a single type symbol, where TextSymbolizer related attributes contain the prefix text- and IconSymbolizer related attributes the prefix icon-. However, since all symbol-type properties are optional, we cannot reason if only a Text or an IconSymbolizer should be created, or if both should be created.

Now is the question on how to handle this problem. Should we simply always create both symbolizers or should we only create those symbolizers where e.g. at least one value is not undefined?

The result of both "solutions" would create a non-bijective parser.

jansule commented 3 months ago

solved with https://github.com/geostyler/geostyler-mapbox-parser/pull/287