Sets outline and opacity defaults for polygon fill

geostyler / geostyler-mapfile-parser

GeoStyler Style Parser implementation for MapServer Mapfiles

BSD 2-Clause "Simplified" License

7 stars 5 forks source link

Sets outline and opacity defaults for polygon fill #40

Closed mholthausen closed 11 months ago

mholthausen commented 3 years ago

This MR

uses mapfileStyle.width (if defined) as outlineWidth
sets default values for outlineOpacity and opacity
- depending on mapfileStyle.color and mapfileStyle.outlineColor the corresponding opacity values (fillOpacity and outlineOpacity) are set to the defined value or a default value
provides a new test case for polygons defined with separate styles for fill and outline values

@KaiVolland @jansule please review

mholthausen commented 3 years ago

The result will be

{
  "kind": "Fill",
  "color": "#0E1058",
  "fillOpacity": 1, // beacuse color is defined
  "outlineOpacity": 0 // beacuse there is no outlineColor defined
}

Additionally the way (writeStyle) to generate a Mapfile from geostyler-style is not implemented yet.

jansule commented 3 years ago

I think this will add unneeded information to the geostyler-stlye.

I think our concept of file based similarity is a little outdated. It might be better to follow a visual-similarity-approach.

There is already an issue for this (https://github.com/geostyler/geostyler/issues/1444) and this should also be discussed in the next monthly (https://github.com/geostyler/geostyler/discussions/1451).

IMHO, this should be non-blocking for now.