geostyler / geostyler-openlayers-parser

GeoStyler Style Parser implementation for OpenLayers styles

BSD 2-Clause "Simplified" License

36 stars 26 forks source link

Fixes opacity of ol mark symbolizer #667

Closed KaiVolland closed 1 year ago

KaiVolland commented 1 year ago

Description

This fixes the opacity when writing an MarkSymbolizer to Openlayers style.

The CircleStyle and RegularShapeStyle have opacity as property so we can use it instead of FillOpacity
They don't allow the opacity as a constructor option so we have to set it after creation of the style with setOpacity.

Related issues or pull requests

620

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Dependency updates
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
[x] I have followed the guidelines for contributing
[x] The proposed change fits to the content of the code of conduct
[ ] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[ ] I'm lost; why do I have to check so many boxes? Please help!