Fix scale check - Githubissues

geostyler / geostyler-openlayers-parser

GeoStyler Style Parser implementation for OpenLayers styles

BSD 2-Clause "Simplified" License

38 stars 28 forks source link

Fix scale check #681

Closed hwbllmnn closed 1 year ago

hwbllmnn commented 1 year ago

Description

Fixes the scale check for null values. Previously the scale check would lead to an out of scale determination if max or min was set to null.

Pull request type

[x] Bugfix
[ ] Feature
[ ] Dependency updates
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
[x] I have followed the guidelines for contributing
[x] The proposed change fits to the content of the code of conduct
[x] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[ ] I'm lost; why do I have to check so many boxes? Please help!

@geostyler/devs Please review.