Clone style to avoid manipulation - Githubissues

geostyler / geostyler-openlayers-parser

GeoStyler Style Parser implementation for OpenLayers styles

BSD 2-Clause "Simplified" License

36 stars 26 forks source link

Clone style to avoid manipulation #741

Closed KaiVolland closed 12 months ago

KaiVolland commented 1 year ago

Description

This PR makes use of structuredClone when writing the style to avoid manipulation of the input object.

It also pushes null to the styles array when the visibilty of a symbolizer is set to false.

Related issues or pull requests

Fixes #740

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Dependency updates
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
[x] I have followed the guidelines for contributing
[x] The proposed change fits to the content of the code of conduct
[x] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[ ] I'm lost; why do I have to check so many boxes? Please help!