miccoh1994 commented 6 months ago

Description

Fixes a bug when both arguments to a comparison filter are property functions. The parser would extract the property from the feature and then use the value as a key for the feature again. e.g. feature.get(feature.get('x'));

Related issues or pull requests

791

Pull request type

Please check the type of change your PR introduces:

[x] Bugfix
[ ] Feature
[ ] Dependency updates
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe)
[ ] I am unsure (we'll look into it together)

Do you introduce a breaking change?

[ ] Yes
[x] No
[ ] I am unsure (no worries, we'll find out)

Checklist

[x] I understand and agree that the changes in this PR will be licensed under the BSD 2-Clause License
[x] I have followed the guidelines for contributing
[x] The proposed change fits to the content of the code of conduct
[x] I have added or updated tests and documentation, and the test suite passes (run npm test locally)
[ ] I'm lost; why do I have to check so many boxes? Please help!

miccoh1994 commented 6 months ago

force pushed to squash and fix a typo

jansule commented 2 weeks ago

:tada: This PR is included in version 5.0.0-next.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jansule commented 1 week ago

:tada: This PR is included in version 5.0.0 :tada: