geostyler / geostyler-openlayers-parser

GeoStyler Style Parser implementation for OpenLayers styles
BSD 2-Clause "Simplified" License
38 stars 28 forks source link

Update OlStyleParser.ts fixing issue 795 #796

Closed xevxx closed 8 months ago

xevxx commented 8 months ago

Bug fix for scope declared variables in geoStylerFilterToOlParserFilter method

Thank you 💞

Thank you for considering giving code and/or documentation back to this project, you're awesome and we appreciate your work.

Some guidelines for the proposed change

Please review the guidelines for contributing and the code of conduct of this repository. This makes it easy for you to give back and for us to accept your changes.

Please use the template below the line for the pull request description, and make sure to tick off the boxes in the checklists. In your final pull request everything above the next horizontal line can be removed to not distract reviewers or other readers.

Again: thank you for your contribution.


Description

geoStylerFilterToOlParserFilter Filter or rule only breaking bug with suggested fix issue #795 geoStylerFilterToOlParserFilter in the switch statement, intermediate and restFilter are declared in the && case but used in the || case, this breaks if you only have an or filter.

Related issues or pull requests

795

Pull request type

Please check the type of change your PR introduces:

Do you introduce a breaking change?

Checklist

KaiVolland commented 8 months ago

Thanks a lot.

I'll had to squash merge and modifiy the commit message it was not matching the conventional commit syntax this repository relies on.

xevxx commented 8 months ago

Thanks, ill follow that process if i do anything else.

Thank you

jansule commented 3 months ago

:tada: This PR is included in version 5.0.0-next.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jansule commented 3 months ago

:tada: This PR is included in version 5.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: