search

geostyler / geostyler-sld-parser

GeoStyler-Style-Parser implementation for SLD
BSD 2-Clause "Simplified" License
52 stars 34 forks source link

Fix generate Format tag #970

Closed tltk90 closed 1 week ago

tltk90 commented 2 weeks ago

Could solve #962

KaiVolland commented 2 weeks ago

Hey @tltk90, thanks for your contribution.

Could you add a new test with a corresponding SLD and geostyler-style?

tltk90 commented 2 weeks ago

@KaiVolland I think the existing tests are sufficient, I had a spelling error, that's why the tests failed earlier. I fixed it. The test can write a SLD PointSymbolizer with ExternalGraphic

KaiVolland commented 2 weeks ago

If the tests were sufficient they should have failed before your MR :smile: . Or in other words; could you add a test that demonstrates the correct translation of a graphic with an extension?

... or just add an SLD to the issue that failed before this PR. I can add it afterwards.

tltk90 commented 2 weeks ago

Sorry on the delay with the answer, The "problem" with the tests is the Format tag is not part of the geostyler object, and in all the tests we you need to compare sld you convert it back to geostyler object, so you don't catch this problem.

You can see this in the test can write a SLD 1.1 PointSymbolizer with ExternalGraphic svg if you print the sldString before convert it back to geostyler you see the format was missing.

KaiVolland commented 1 week ago

Thanks for the contribution @tltk90 :pray: