[geostyler-style] Property duplicates

[jansule]

Some properties in geostyler-style refer to the same property (event though they have different names). It looks as if some properties where derived from mapbox and others from sld. We should decide on only one of each and remove the other, respectively.

FillSymbolizer

• [x] graphicFill vs fillPattern

My proposal is to remove the fillPattern property, as it is not being used yet and is not as powerful as graphicFill (specifying the url to an image vs specifying a point symbolizer).

LineSymbolizer

• [x] perpendicularOffset vs offset
• [x] graphicFill vs pattern
• [x] graphicStroke vs gradient

[KaiVolland]

Seems like we missed the fillPattern property when creating the graphicFill stuff for SLD. The first approach was to be as close as possible to the MapBox naming, but my opinion on this is not that strong.

[jansule]

Seems like we missed the fillPattern property when creating the graphicFill stuff for SLD

I guess you are right there.

The first approach was to be as close as possible to the MapBox naming

For me it would be fine to use fillPattern instead of graphicFill. Then, we would have to change this in a few places (SLDParser, GeoStyler) which should be not too much work.

But does it make sense to be as close as possible to the mapbox naming even if the type definition is different, or will this rather create confusion? In this case, fillPattern would contain a complete PointSymbolizer, whereas in mapbox it just contains the name of the sprite as a string.

[KaiVolland]

I think we can remove the fillPattern and go with graphicFill for now.

[KaiVolland]

@jansule could you explain in what way these props are equivalent:

graphicFill vs pattern graphicStroke vs gradient

[jansule]

graphicFill and (line-)pattern both relate to a repeated pattern of an image (or symbol) in a line. graphicFill is the term used by sld and allows more customization as (line-)pattern, the term used by mapbox. It actually is the same as fillpattern, I just wanted to highlight that it also applies for lines.

graphicFill (sld)

The \<GraphicFill> element contains a \<Graphic> element, which specifies a graphic image or symbol to use for a repeated fill pattern. The syntax is described in the PointSymbolizer Graphic section.

pattern (mapbox)

Name of image in sprite to use for drawing image fills.

---

graphicStroke and gradient seem to be two distinct props.

[KaiVolland]

Closing this as al the duplicates have been resolved in the meantime.