search

geostyler / geostyler-style

Style declaration files for the GeoStyler project
https://geostyler.github.io/geostyler-style/docs/master/
BSD 2-Clause "Simplified" License
16 stars 15 forks source link

Add support for image sprites #583

Closed KaiVolland closed 7 months ago

KaiVolland commented 9 months ago

This adds support for sprites to the IconSymbolizer. It will enhance parsing mapbox styles as they fully rely on sprites: https://docs.mapbox.com/style-spec/reference/sprite/#sprite-files

IMHO it is a breaking change as the UI and other parsers will fail handling a style with a Sprite.

BREAKING CHANGE: IconSymbolizer.image can be a Sprite

Related to https://github.com/geostyler/geostyler-mapbox-parser/issues/290

simonseyock commented 9 months ago

Is this really a breaking change? It only adds functionality and does not add/break old functionality (as far as I see).

KaiVolland commented 9 months ago

Is this really a breaking change? It only adds functionality and does not add/break old functionality (as far as I see).

It will break old functionality if you make use of a Sprite. Parsers and UI wont be able to handle this and potential crash or throw errors.

dnlkoch commented 7 months ago

:tada: This PR is included in version 8.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: