Closed fperucic closed 1 year ago
Thanks for the info @fperucic. Are you planning on providing a fix for this?
Hi, tried to fix this, but with no luck, due to lack of experience with TypeSript/React.
Fixes to the FilterTree.tsx
seem easy for my level, since the locale is already there, but I do not where to start with TextFilterField.tsx
and AttributeCombo.tsx
Alright, no problem. The general approach for adding locales is as follows:
locale
as default prop (example)locales
type (example)localize
hoc (example)It might help to take a look at ColorField, as this component is very lightweight.
The different filters themselves will now be translated (kudos to @mholthausen #1866).
What's still missing is a translation for the Change Filter
text, as well as translations for the input placeholders and error texts.
This issue is stale because it has been open for 180 days with no activity. Feel free to unstale it at any time by adding a comment.
This is still relevant.
This issue is stale because it has been open for 180 days with no activity. Feel free to unstale it at any time by adding a comment.
This is solved with #1866
Bug
Describe the bug FilterEditor strings are not translated, they are hardcoded in english
To Reproduce Steps to reproduce the behavior:
Expected behavior User should see the translated strings
Screenshots