search

geotrellis / geotrellis-pointcloud

GeoTrellis PointCloud library to work with any pointcloud data on Spark
Apache License 2.0
26 stars 10 forks source link

Mesh Rasterization Bug #47

Closed pomadchin closed 4 years ago

pomadchin commented 4 years ago

seam-bug

The following unit captures a bug: https://github.com/geotrellis/geotrellis-pointcloud/pull/46/files#diff-f3b763efd172586c5a244c399cc9821bR103-R106

Unit test code:

ignore("rasterizer bug") {
  val ge = new GridExtent[Long](Extent(481968.0, 4390186.0, 482718.32558139536, 4390537.069767442), 6.883720930232645, 6.883720930227462, 109, 51)
  val rs = DEMRasterSource(catalog).resampleToRegion(ge)
  GeoTiff(rs.read().get, rs.crs).write("/tmp/test.tiff")
}
pomadchin commented 4 years ago

In the png from the topic description, you could notice a small seam; it turned out to be also a bug of a rasterizer but a bit different. An extra test was added to track it down: https://github.com/geotrellis/geotrellis-pointcloud/commit/bd11b894c2a6181a824c166320e8a21e857dbb65#diff-f3b763efd172586c5a244c399cc9821bR112

download (31)

The bug is visible in the first line of this picture in the top left corner.

pomadchin commented 4 years ago

The last one was actually a reprojection bug (that could only be visible with the nn reprojection application)!

image