GeoTrellis 3.2.0 - Githubissues

geotrellis / maml

Map Algebra Modeling Language: It's what we and whales are.

https://geotrellis.github.io/maml/

Apache License 2.0

16 stars 10 forks source link

GeoTrellis 3.2.0 #112

Closed echeipesh closed 4 years ago

echeipesh commented 4 years ago

Overview

Cross scala version dependencies diverge (ref: https://github.com/locationtech/geotrellis/pull/3132)
Minimize dependencies for mamlJVM
- logging dependency becomes Test
- spark-sql dependency becomes Test
- lose geotrellis-spark dependency
- lose geotrellis-s3 dependency
switch from scala-logging to log4s
ParallelInterpreter forked for scala 2.11 and 2.12 based on changes in cats.Parallel interface

Checklist

[x] Description of PR is in an appropriate section of the CHANGELOG and grouped with similar changes if possible

echeipesh commented 4 years ago

[error] /home/circleci/project/jvm/src/main/scala/eval/ParallelInterpreter.scala:16:19: wrong number of type arguments for cats.Parallel, should be 1
[error]     implicit Par: Parallel[F, G],
[error]                   ^
[error] /home/circleci/project/jvm/src/main/scala/eval/ParallelInterpreter.scala:33:27: could not find implicit value for parameter P: cats.Parallel[F]
[error]       expression.children parTraverse { expr =>
[error]                           ^
[error] /home/circleci/project/jvm/src/main/scala/eval/ParallelInterpreter.scala:60:19: wrong number of type arguments for cats.Parallel, should be 1
[error]       implicit P: Parallel[T, U],
[error]                   ^
[error] three errors found

This is one of the API breaks sadly

Cats 1.6 https://github.com/typelevel/cats/blob/2fa0956a1a0b560bf12fb18a2b85c935e5aab342/core/src/main/scala/cats/Parallel.scala#L57

Cats 2.0 https://github.com/typelevel/cats/blob/c8244d433f8f36183077e4480283b1333c0f55fb/core/src/main/scala/cats/Parallel.scala#L58