geotrellis / maml

Map Algebra Modeling Language: It's what we and whales are.
https://geotrellis.github.io/maml/
Apache License 2.0
16 stars 10 forks source link

Add MaskingNodes for different types of tiles #80

Closed jisantuc closed 5 years ago

jisantuc commented 5 years ago

Overview

This PR turns MaskingNode into an ADT with options for different arities of source data (unary, ternary, quaternary) and adds a failing test where my guess about what should have happened as a result turned out to be wrong.

The reason for this is that we currently can't mask any kind of non-single band imagery result, which is a drag, because in RF for single band viz of mosaics we return a multiband tile of the RGBA channels after rendering, and for multiband viz of mosaics we return an RGB tile.

Testing

jisantuc commented 5 years ago

The test I added doesn't currently pass, and I'm not sure why -- evaluation of Masking directives squashes everything down to a single band, but I didn't figure out where / how that's happening.

jisantuc commented 5 years ago

Superseded by #89