52-proposal-1 - Githubissues

joschne commented 10 months ago

This PR aims to add some features and improvements:

In geov-list-item-nested-properties

Group by predicate and count in the sparql query (instead of filtering in JavaScript)
Display a count for each property
Add links to properties and classes
Add links to entities
Wrap literals in existing components for literals
Exclude time span query to separate component geov-time-span

Add geov-time-span

Component to query time span props and create a readable string

In geov-entity

Add geov-time-span

joschne commented 10 months ago

This PR is challenged by #102 The main difference is the visual design of geov-entity and its subcomponents. Which one do you prefer @perrauda ?

perrauda commented 10 months ago

This PR is challenged by #102 The main difference is the visual design of geov-entity and its subcomponents. Which one do you prefer @perrauda ?

The redesign is effective in terms of the layout of the entities. But I think that the entities should have a different background (white or maybe other color?), I'm having a bit of trouble distinguishing them.

joschne commented 10 months ago

closing in favor of #102

geovistory / design-system

52-proposal-1 #101