geovistory / design-system

MIT License
2 stars 1 forks source link

Sb on webcomponents #69

Closed perrauda closed 1 year ago

perrauda commented 1 year ago

Current status of the PR:

The geovistory webcomponents have been updated: wrapped with the stencilWrapper function. The storybook configuration seems to be OK for now, to be continued We currently need to change the Welcome and Getting started files... I haven't managed that yet (see welcome.stories.tsx)

flicksolutions commented 1 year ago

When I run npm run dev from the root folder I get the following error:

[📕_STORYBOOK] Failed to resolve import "../dist/esm/polyfills/index.js" from "loader\index.js". Does the file exist?
[📕_STORYBOOK] 16:36:43 [vite] Internal server error: Failed to resolve import "../dist/esm/polyfills/index.js" from "loader\index.js". Does the file exist?

The file in fact does not exist! It doesn't matter how long i let the STENCIL task sleep, the error persists. If I run npm run dev a second time, the file is generated and there is no error. Also, if I run npm run dev in the package/design-system-web -folder, the error is not generated... I hope this is a small fix...

joschne commented 1 year ago

When I run npm run dev from the root folder I get the following error:

[📕_STORYBOOK] Failed to resolve import "../dist/esm/polyfills/index.js" from "loader\index.js". Does the file exist?
[📕_STORYBOOK] 16:36:43 [vite] Internal server error: Failed to resolve import "../dist/esm/polyfills/index.js" from "loader\index.js". Does the file exist?

The file in fact does not exist! It doesn't matter how long i let the STENCIL task sleep, the error persists. If I run npm run dev a second time, the file is generated and there is no error. Also, if I run npm run dev in the package/design-system-web -folder, the error is not generated... I hope this is a small fix...

We could not find the cause of the issue. Instead we add a workaround description in README.md