package updates against vulnerabilities

geovistory / design-system

MIT License

2 stars 1 forks source link

package updates against vulnerabilities #70

Closed flicksolutions closed 1 year ago

flicksolutions commented 1 year ago

In reviewing #69 i found that the critical vulnerabilities should be closed and storybook should be updated aswell. I removed the lerna bootstrap scripts and everything seems to work just fine.

Next steps

merge #69 into main
merge main into this (#70)
review this
merge into main

this is also for https://github.com/geovistory/design-system/issues/62

flicksolutions commented 1 year ago

npm run storybook fails, because banner.js trys to import ESM Modules by require. Can you fix that @joschne ? Or should I try to do it?

flicksolutions commented 1 year ago

OK, I have a new issue @joschne (the banner-issue is fixed) : I used top-level await to solve the issue raised by @perrauda - but on build, the builder raises an error, that it is not allowed in the targeted version (top-level await is a relatively new feature but very well supportet). Can you tell me where to set the target-version correctly?

joschne commented 1 year ago

@flicksolutions PR can be closed when #86 is approved