geovistory / design-system

MIT License
2 stars 1 forks source link

Add icon to geov-entity #79

Closed joschne closed 1 year ago

joschne commented 1 year ago

The header of a geov-entity should show an icon for some classes (e.g Person, Group, Geographical Place).

image

As the component can display any class, it must still work for classes that have no icon specified. The alignment of the icon must work on all display sizes.

perrauda commented 1 year ago

Added a new component: Entity Class Icon This component return an icon corresponding with class label (Here, a person) Image

the size is not managed directly, it must be managed by the webcomponent which uses this webcomponent

Here in geov-entity

Image

I'd be delighted to hear your views on the placement of the icon

Implemented for: Person

Image

Geographical Place

Image

Group

Image

Ship Voyage

Image

Date Time Description

Image

perrauda commented 1 year ago

Text

Image

flicksolutions commented 1 year ago

I added some comments in my pending review to this. I'm going to review the rest of the tickets later - that's why the review isn't finished.