search

geovistory / design-system

MIT License
2 stars 1 forks source link

5 small issues for #76 #84

Closed perrauda closed 1 year ago

perrauda commented 1 year ago

Resolves #79 Resolves #77 Resolves #78 Resolves #82 Resolves #81

perrauda commented 1 year ago

Thanks to both of you for the code reviews, I've applied the changes linked to your observations as best I can.

A small button now appears if the text is too long, and opens a modal with the full text.

What doesn't work (at first sight) is that the calculation of whether or not the text is too long when you resize the window doesn't seem to be triggered by the resize event.

And maybe also improve the modal interface (too empty, adapt the content?).

joschne commented 1 year ago

What doesn't work (at first sight) is that the calculation of whether or not the text is too long when you resize the window doesn't seem to be triggered by the resize event.

For me this works.

And maybe also improve the modal interface (too empty, adapt the content?).

I find it ok as it is. The strings will be of very different length.