Correcting issue with TestFixtureSetup

gep13-archive / WebApiSample

Sample Web API Project with various pieces AutoFac, AutoMapper, NUnit

MIT License

7 stars 5 forks source link

Correcting issue with TestFixtureSetup #7

Closed gep13 closed 10 years ago

gep13 commented 10 years ago

Made sure to use TestFixtureSetup only for things that need to be setup once, and only once for all tests
Moved everything else into a SetUp method, which gets called before each test runs.

gep13 commented 10 years ago

@NathanGloyn Thoughts?

NathanGloyn commented 10 years ago

I have to say I'm not a fan of using this throughout a class, what value do you see using it gives over it not being used?

gep13 commented 10 years ago

I have to say I'm not a fan of using this throughout a class, what value do you see using it gives over it not being used?

Simply that is specifies the scope of the variable that you are consuming. I much prefer using this as opposed to using _ to suffix variables defined at the class scope.

I guess it is a personal preference, but it is one that has stuck around since enabling StyleCop on work projects.

gep13 commented 10 years ago

@NathanGloyn were did we get to with this? Are you happy to proceed with StyleCop rules in place, or you wanting to turn that off?

gep13 commented 10 years ago

@NathanGloyn ok, let me know what you think.

Also, I am happy for you to rebase this PR, to get rid of the merge conflict, if you want to.

gep13 commented 10 years ago

@NathanGloyn this will need to get fixed:

https://ci.appveyor.com/project/GaryEwanPark/webapisample/build/0.2.0-PullRequest.7+4%20(Build%2038)/tests

Or overridden.

gep13 commented 10 years ago

Going to close this PR, and looks like something has went quite horribly wrong, and I can't get it to merge back into develop. Will create a fresh branch and PR from there.