gep13-oss / ChocolateyPackages

Packages for publishing on the Chocolately Nuget Feed
19 stars 4 forks source link

Updated calibre to 1.15.0, better icon, added Thumbs.db to .gitignore #3

Closed TomOne closed 10 years ago

TomOne commented 10 years ago

Remember that .ico files are not suitable as package icons, because web browsers don’t pick out the right resolution like the Windows UI does. So .ico files with multiple embedded images would only unnecessarily increase the file size. Look at the difference: calibre.ico: 160 KiB calibre.png at 128 px: 21.4 KiB

Unfortunately I couldn’t find the changelog of Calibre 1.15.0 in the format like you have in the package, so I didn’t touch it.

By the way, don’t forget to merge this: https://github.com/gep13/ChocolateyAutomaticPackages/pull/1 It’s actually less work to set up automatic packages than it looks like. :)

gep13 commented 10 years ago

This was merged here:

https://github.com/gep13/ChocolateyPackages/commit/522e72c8d114929ec44b791f6a3a92ef2e4aad4e

gep13 commented 10 years ago

Thanks for taking the time to do this, I really appreciate it. It was on my list of things to look at :-)

Yes, I haven't forgotten about the Automatic Packages, this is still on my todo list, it is just that there are other things with a higher priority unfortunately.

TomOne commented 10 years ago

Thanks.

Btw: With automatic packages it gets a bit complicated to insert the release notes. A script which extracts the release notes from the website, formats them and inserts them into the nuspec would be necessary.

But personally I think it’s much more important to have automatic packages with quick updates to the latest software versions rather than having manual packages with manually inserted release notes where Chocolatey users have to wait several days, weeks or even months until the maintainer has time to update the package. :smiley:

In addition every interested user can look at the release notes of the software on the origin website, so it’s not absolutely necessary to include them.

gep13 commented 10 years ago

Although I agree with what you are saying, in my case, even with automatic packages, I couldn't guarantee that a package would be ready any sooner. I would need to run Keratin on my main machine, and in all honesty, with everything that is going on just now, I can go several days without this machine even being switched on. Having said that, as I have said, getting it up and running is something that I want to do, but it will just take time to get round to it.

TomOne commented 10 years ago

I couldn't guarantee that a package would be ready any sooner.

Yes, but at least for me the the probability for it is higher that I do it sooner when I just need a few seconds to launch Ketarin instead of requiring several minutes for the manual update process for every single package.

Btw. Why did you only update to Calibre 1.14.0?

gep13 commented 10 years ago

We will have to agree to disagree at the minute.

Doh! I forgot to hit the TeamCity build to push the changes to Chocolatey.org. Should be there now.

TomOne commented 10 years ago

Should be there now.

Thanks :+1:

We will have to agree to disagree at the minute.

Sorry, it wasn’t my intention to bother you.