search

gep13-oss / PoshBot.Soon

MIT License
2 stars 2 forks source link

Update URLs to point to correct place #6

Closed mkevenaar closed 5 years ago

mkevenaar commented 5 years ago

The current release notes point to https://raw.githubusercontent.com/gep13/PoshBot.Soon/develop/CHANGELOG.md and it does not exist.

gep13 commented 5 years ago

@mkevenaar I am not a fan of duplicating information if we can avoid it. In this case, I think we should change the URL to be:

https://github.com/gep13-oss/PoshBot.Soon/releases

Thoughts?

mkevenaar commented 5 years ago

Yip I agree. I was just following what was already there

AdmiringWorm commented 5 years ago

@gep13 @mkevenaar if you can, maybe point the release notes url directly to the exact release that was built?

mkevenaar commented 5 years ago

@AdmiringWorm That would mean that we need to change the ReleaseNotes URL on every release. I think pointing to the releases page is perfectly acceptable.

mkevenaar commented 5 years ago

Besides ReleaseNotes URL also the following URLs have been fixed:

mkevenaar commented 5 years ago

This is implemented here: https://github.com/gep13-oss/PoshBot.Soon/commit/d4a9a0561203bb78870dcafa8f4ab70cc397309a