search

gepd / Deviot

Sublime Text plugin for IoT development based in PlatformIO ecosystem (Arduino IDE)
Apache License 2.0
307 stars 56 forks source link

DEV linter errors persist #264

Open tablatronix opened 6 years ago

tablatronix commented 6 years ago

It seems that linter context errors, stay in a buffer even after recompile. If there is an error, previous errors show back up, even after closing them.

reproduce

make syntax error compile bad close red errors

compile successfully make different syntax error (not needed) compile

same errors show back up from first time

tablatronix commented 6 years ago

any ideas how to clear these out without restarting?

screen shot 2018-10-31 at 8 31 53 am 2

tablatronix commented 6 years ago

self.errs_by_file[file] is never cleared, errors just keep appending. not sure where to put a clear for compile command only? or how to get self.file in command, for now I am just emptying the entire thing on command().

also It seems not very efficient to be processing errors and phantoms ondata constantly, not sure if there is a way to do it once at end, probably doesn't matter, but it seemed like excessive processing, unless there is some benefit I am not thinking of

gepd commented 6 years ago

I've pushed a temporal fix for this issue, let me know if it's better

tablatronix commented 6 years ago

No, also I did not see any commits related to this fix, you sure it pushed?

tablatronix commented 6 years ago

if you mean this? https://github.com/gepd/Deviot/commit/5560fb3633c7c66f6332ee18ef12530e1e60ef37

thats just the setting toggle

gepd commented 6 years ago

Indeed, something happened to the fix, I've pushed it again

tablatronix commented 5 years ago

works great, what do you think about clearing errors after successful compile, if you do not X them they just stick around