search

gepd / Stino

A Sublime Text Plugin for Arduino
Other
33 stars 10 forks source link

Replace "{archive_file_path}" placeholder in ar_cmd to fix build problem with 1.6.6 #17

Closed xchrdw closed 8 years ago

xchrdw commented 8 years ago

build was broken with 1.6.6 because the pattern for core.a has a new placeholder ("{archive_file_path}")

Is this the right fork to contribute to?

gepd commented 8 years ago

Hi @xchrdw, thanks for you contribution, you can contribute on this fork or the Robot Will's I can merge in both repositories.

The only thing I'm worried of this change, is that it will break the compatibility of older versions, It should change base on the Arduino IDE version

xchrdw commented 8 years ago

I think this change should only matter if ar_cmd contains {archive_file_path}. If it doesnt nothing will be replaced so it shouldnt break older versions. If you think that there is still a possible problem I will change it. Just give me a hint where can find the version or similar version dependent behaviour.

gepd commented 8 years ago

I was looking in the code and I didn't found anything about versions, so I guest it will took more time to implement something like that. Meanwhile I'll merge this request.

Thanks for your contribution.