gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.
270 stars 620 forks source link

Updated event graph layout for gephi 0.9. #113

Closed WouterSpekkink closed 8 years ago

WouterSpekkink commented 8 years ago

I noticed that floats and Float objects can no longer be cast to Double objects, and that doubles or Double objects cannot be cast into Float objects. This was possible with the previous API of Gephi, as far as I know. Now Gephi will throw an error of such casting is attempted. The same happens with the GeoLayout plugin I have noticed.

eduramiba commented 8 years ago

Hi, The cast is no longer possible because Gephi used to store primitive numbers (float, double) but now stores Float or Double for example, so autoboxing is not possible.

eduramiba commented 8 years ago

Sorry for the delay, I created a pull request on your branch so we can finally merge this :)

WouterSpekkink commented 8 years ago

Hi Eduardo,

Thanks for picking up the work on the plugins. I'm a bit new to these merger issues. Is it just a matter of me going through your edits and merge your pull requests on my branch, or is there more I should do?

Also, I think I fixed the casting issue before right? I remember that after reporting the issue for GeoLayout, I came up with another solution that doesn't use casting with primitives.

Best,

Wouter

eduramiba commented 8 years ago

Hi Router, Yeah, the fix for casting numbers is perfect. Also you only need to merge my pull requests and your plugin will be available shortly when I merge this.

eduramiba commented 8 years ago

Wouter* sorry bad auto correct haha

WouterSpekkink commented 8 years ago

Router, that's a new one :) No worries, you should hear the various pronunciations of my name that I've heard. Thanks Eduardo!

Wouter

2016-09-11 14:04 GMT+01:00 Eduardo Ramos notifications@github.com:

Wouter* sorry bad auto correct haha

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gephi/gephi-plugins/pull/113#issuecomment-246179237, or mute the thread https://github.com/notifications/unsubscribe-auth/AGgoXmhCdMi4GtFxQy05RL5m-sP0eOZwks5qo_xtgaJpZM4IpRil .

eduramiba commented 8 years ago

Your plugin is now available at the update center :smiley: