Similarity Computer plugin

gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.

270 stars 620 forks source link

Closed seinecle closed 7 years ago

seinecle commented 7 years ago

Hello Eduardo,

Here is another plugin migrated to 0.9.1! Your explanations from the last migrations were so useful to get it done alone this time!

eduramiba commented 7 years ago

Awesome! I will get to this pull request soon 😃

eduramiba commented 7 years ago

Hi Clement, Were you able to check the suggested changes?

If not, I can do it sometime but not sure when I will have the time.

seinecle commented 7 years ago

I am on it, I actually take this opportunity to revamp it

seinecle commented 7 years ago

Ok here is my new pull request - made the changes you recommended, added new stuff, refactored a lot. Much cleaner.

eduramiba commented 7 years ago

Hi, A quick look at the code still shows a few problems:

The Wizard package is still not refactored to net.clementlevallois
The sourcecode url in pom.xml is still missing
There are calls to System.out, logger should be used instead
The sonatype-snapshots is still in pom, and not used by any dependency
There seems to be a lot of unnecessary Bundle.properties files in src/main/resources. It seems only Wizard (for GUI) and Controller (used from manifest) folders are used. These also should be placed on the same package as classes.

Thanks!

seinecle commented 7 years ago

OK thanks for your the code review!! Doing it today.

seinecle commented 7 years ago

Updated according to your comments

eduramiba commented 7 years ago

Merged, thanks! Will be published shortly

eduramiba commented 7 years ago

seinecle commented 7 years ago

Fantastic - thx for the great work!