search

gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.
270 stars 620 forks source link

Multimode #173

Closed joancf closed 6 years ago

joancf commented 6 years ago

168

eduramiba commented 6 years ago

Hi, Thanks for the pull request! I will take a look as soon as possible. But please you should only change the version and author in the pom.xml (and add needed dependencies). No other changes should be necessary (for example the plugin config, and you don't need to repeat gephi.version, as that dependency version is already managed in parent pom)

eduramiba commented 6 years ago

Related issue: https://github.com/gephi/gephi/issues/1854

eduramiba commented 6 years ago

Thanks, I finally merged this but had to add several fixes and sorted out the code a bit.

See https://github.com/eduramiba/gephi-plugins/commit/083b56b04fd1bb40024f0badf206eb981a11af56

The problem with not creating any edges (https://github.com/gephi/gephi/issues/1854) was for directed graphs due to the changes in https://github.com/gephi/gephi-plugins/pull/131 where the condition of neighbors for second matrix was changed from being neighbor to getting the edge weight, but in a directed graph it won't work because getEdge takes into account edge direction.

Now it will treat any graph as undirected unless directed option is checked. It will also sum the weights in case of parallel edges.