Closed vtraag closed 5 years ago
Hi Vicent, This is awesome, thanks for the quick implementation!! I will review the plugin as soon as possible and should be easy to merge. Later, if you have a maven artifact we can update the code to use it.
Cheers!
Hi Vincent, Finally your plugin is merged and should be available soon. Thank you very much for the effort and the patience for this to be merged.
I made some small corrections to your code, so please be sure to merge the following pull request into your codebase so you can later update the plugin: https://github.com/vtraag/gephi-leiden-plugin/pull/1
Your plugin is now available at https://gephi.org/plugins/#/plugin/leiden-algorithm-gephi-plugin and in Gephi - Tools - Plugins menu
Great! Thanks for merging it and making it available!
I'll be sure to merge any changes back in my fork.
The URL in the Plugin Manager Description: Homepage: http://github.com/gephi/gephi-plugins/leiden-algorithm-gephi-plugin does not seem to be correct. Perhaps change to: https://gephi.org/plugins/#/plugin/leiden-algorithm-gephi-plugin
Thanks @mbingenheimer, I just moved your message to an issue in the gephi-leiden-plugin repository https://github.com/vtraag/gephi-leiden-plugin/issues/3.
@eduramiba, perhaps best to close the pull request? I've merged back the changes in my fork.
@vtraag Sure, what request? I think everything is correct and merged.
Sorry, perhaps I misunderstood, I thought it was merged but not closed. I thought once the pull request was closed, it wouldn't be possible to comment on it any longer? But apparently it is?
Yeah I think comments can be added unless I block them
OK, no problem, good to know, thanks!
This plugin provides an implementation of the Leiden algorithm (based on https://github.com/CWTSLeiden/networkanalysis) for community detection, see that repository for more details. It is quite complete as is, I believe, including several configuration options. More information about each option is provided in tooltips.
There are some specific points you may wish to check:
RunClusteringBuilder
is actually required? I simply included this because it was also used by for the modularity plugin.As requested in
README.md
I now created the pull-request withmaster-forge
branch as the base, but it cannot merge automatically (I did merge upstream changes). If it should be merged with themaster
branch instead, let me know.The current implementation simply relies on a copy of the source code at https://github.com/CWTSLeiden/networkanalysis, since the package is not yet in maven. Whenever it becomes available through maven, it should simply be declared a dependency, since no adaptation of the code is required.