search

gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.
269 stars 620 forks source link

Add KatzCentrality plugin. #231

Closed yossisp closed 1 year ago

yossisp commented 2 years ago

The plugin adds Katz Centrality calculation in Statistics module.

mbastian commented 2 years ago

Hi @yossisp I would like to propose some changes to your PR in light of the recent Gephi upgrades. In this PR, could you enable my contributions please, via https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thank you!

yossisp commented 2 years ago

Hi @yossisp I would like to propose some changes to your PR in light of the recent Gephi upgrades. In this PR, could you enable my contributions please, via https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

Thank you!

Hi @mbastian, sure no problem, I see that "Allow edits by maintainer" checkbox is checked, please let me know if you have any issues adding your commits.

mbastian commented 2 years ago

Thanks @yossisp! Unfortunately it seems that your branch is a fork from master-forge instead of master. Normally there should only be your module in there. Therefore I created a new branch with your code directly on this repository. I've made some updates to make the plugin work for the recent Gephi version. You can check it out and see if it works fine for you too.

mbastian commented 2 years ago

Ah also, I don't know if you had a chance to look at the alternative implementation on this other PR: https://github.com/gephi/gephi-plugins/pull/186

Your implementation relies on Matrices while this other doesn't. I'm afraid matrices would take a lot of memory but it might be faster.

yossisp commented 1 year ago

Thanks @yossisp! Unfortunately it seems that your branch is a fork from master-forge instead of master. Normally there should only be your module in there. Therefore I created a new branch with your code directly on this repository. I've made some updates to make the plugin work for the recent Gephi version. You can check it out and see if it works fine for you too.

Thanks @mbastian ! I used the katz centrality nbm file from the branch you created and it seems fine, but I also want to check with the university I developed the plugin for that they also confirm everything works as expected. Will update you as soon as I get their feedback. The only thing is that I get an error when running the plugin via mvn org.gephi:gephi-maven-plugin:run same error as described here I also use Mac. It happened now that I have to use JDK 11 for Gephi.

yossisp commented 1 year ago

@mbastian

Ah also, I don't know if you had a chance to look at the alternative implementation on this other PR: #186

Your implementation relies on Matrices while this other doesn't. I'm afraid matrices would take a lot of memory but it might be faster.

I remember I saw this pr however I'm not sure it even works. Its author didn't respond since 2019. As far as I know the plugin I developed is used by the university which ordered this development and is not causing any memory issues.

mbastian commented 1 year ago

Thanks @yossisp I merged manually from the katz-centrality-plugin branch. Your plugin is now published officially: https://gephi.org/plugins/#/plugin/katz-centrality.

If you want to make some changes, you can do that directly from that branch instead of your fork.

yossisp commented 1 year ago

Thanks @yossisp I merged manually from the katz-centrality-plugin branch. Your plugin is now published officially: https://gephi.org/plugins/#/plugin/katz-centrality.

If you want to make some changes, you can do that directly from that branch instead of your fork.

@mbastian Thanks for publishing! I have a few questions:

  1. Was the code merged to master branch? I don't see it in the master branch of gephi-plugins repo. I also see that the branch is 8 commits ahead of master.
  2. When I go to the plugin page and click on the "Source code" I get "File not found" error.
  3. The images in the plugin page are broken can they be fixed?
mbastian commented 1 year ago

@mbastian Thanks for publishing! I have a few questions:

  1. Was the code merged to master branch? I don't see it in the master branch of gephi-plugins repo. I also see that the branch is 8 commits ahead of master.

The master branch is the template branch for new plugins but the master-forge branch is actually where all the plugins are merged. So one needs to compare to this branch.

  1. When I go to the plugin page and click on the "Source code" I get "File not found" error.

Yes, you can fix this by changing this line. Make sure to also increment your plugin version otherwise changes are not taken in account.

  1. The images in the plugin page are broken can they be fixed?

You use relative paths in your README. Change that to absolute paths and it should work.