Seadragon plugin - Githubissues

gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.

268 stars 620 forks source link

Seadragon plugin #290

Closed totetmatt closed 1 year ago

totetmatt commented 1 year ago

New plugin or plugin update?

[ ] New Plugin
[X] Update

What is the purpose of this plugin?

Able to see large map with opensea dragon.

How to test your plugin in Gephi?

Open Gephi, get a Spatialized Graph
File >> Export >> Seadragon Web ...
Export
Check that file are present in the exported directory
Use of webserver (`python -m http.server is enough) to make sure it works

Checklist before submission

[X] Did you merged with the master branch to get the latest updates?
[X] Did you build and test the plugin successfully locally?
[X] Did you include metadata (e.g. plugin author, license) in the pom.xml file
[X] Did you make sure NOT to include any unecessary files in your PR?
[X] Did you write unit tests to test your plugin functionalities?

totetmatt commented 1 year ago

Great work! Two comments

* Unify the naming. Sometimes it's "SeaDragon", sometimes it's "Seadragon" and sometimes "sea-dragon".

* I guess the resources/org/gephi/plugins/seadragon folder can be deleted?

About naming, If I understand seadragon was the original name, but it got bought by Microsoft, and now the tool available is called opeseadragon. Should we adapt with the "openseadragon" name or keep the old one for "inheritance" purpose ?

Also maybe "export" would be better as "web export" implies the plugin also do web publication, which would avoid confusion ?

mbastian commented 1 year ago

About naming, If I understand seadragon was the original name, but it got bought by Microsoft, and now the tool available is called opeseadragon. Should we adapt with the "openseadragon" name or keep the old one for "inheritance" purpose ?

Also maybe "export" would be better as "web export" implies the plugin also do web publication, which would avoid confusion ?

Yes, maybe better to use "OpenSeadragon" instead. The legacy plugin isn't available since 0.8 so I think inheritance is not so important. So "OpenSeadragon Export" seems good to me.

totetmatt commented 1 year ago

renaming everything so now it's here https://github.com/gephi/gephi-plugins/pull/291