gephi / gephi-plugins

Repository for Gephi Plugins maintained by the team. Each plugin has it's branch.
268 stars 620 forks source link

Fix for 2 critical bugs #297

Closed seinecle closed 1 year ago

seinecle commented 1 year ago

New plugin or plugin update?

What is the purpose of this plugin?

Word cloud

Bug fix

The error was noticed by Veronica Espinoza right after the public release of the plugin: no word cloud is displayed.

The reason for this error, despite the plugin working well at release time, is that I was testing it locally on a wrong (dated) version, instead of the latest version I was working on. Why? Because I was testing the plugin by doing a build on the parent pom, instead of a a clean and build.

After investigation, the plugin does not throw an erorr or crashes, it is just that a condition is always false and as a consequence the methods triggering the display of the word cloud are never run.

-> I have fixed this condition (a Boolean that was inverted)

Then, the wordcloud gets displayed but it always returns the same list of words, which are the top words for the entire graph - not just the nodes being selected. Again, that was due to me testing the plugin on a wrong build, I did not notice it.

Now I made sure I was running the proper version of the plugin, where the selection of top nodes (instead of all nodes) has been correctly implemented.

How to test your plugin in Gephi?

  1. Install, open a network where nodes have a textual attribute. Example of such a file - download it and replace the txt extension with a gexf extension

  2. Select the "description" attribute and run the plugin

Checklist before submission

mbastian commented 1 year ago

I merged but the PR wasn't properly configured. The target branch should be master-forge not master

seinecle commented 1 year ago

Oops sorry