search

gepoch / vim-surround

Surround for the Atom editor.
MIT License
52 stars 2 forks source link

Not working with latest `vim-mode` #27

Closed meleyal closed 9 years ago

meleyal commented 9 years ago

Since updating to vim-mode 0.57.0 surround no longer seems to be working.

gepoch commented 9 years ago

Hmmm... I'm not able to reproduce this.

I'm using

Any chance a reload fixes this?

meleyal commented 9 years ago

Reload didn't fix it. When I try cs ' " the whole line is deleted :(

gepoch commented 9 years ago

Ah! I was investigating the s ' commands.

This is definitely not working right. Thanks for the ticket.

lettertwo commented 9 years ago

I think this may be caused by the recent change in naming from 'command-mode' to 'normal-mode'. I'm just guessing, but lots of my other vim-specific keybindings recently went haywire as a result of that change. I fixed, of course, by updating to use .normal-mode wherever i was previous selecting for .command-mode.

gepoch commented 9 years ago

That's definitely pretty suspicious.

I think I should have some time to get this fixed this weekend. This is a pretty major problem.

lettertwo commented 9 years ago

:+1: I think the fact that the s ' commands still work is a good indicator that the keybindings are likely at fault–.visual-mode didn't get renamed, so those bindings would be unaffected by the name change.

gepoch commented 9 years ago

Fixed in v0.7.4!

You were spot on, @lettertwo. Thanks!

lettertwo commented 9 years ago

Excellent! working like a charm.

meleyal commented 9 years ago

Thanks :)

raiscui commented 8 years ago

I have same problem :When I trycs ' "the whole line is deleted :( in : atom 1.4.2 vim-mode:0.64.0 vim-surround:0.8.1

s work, cs out of work