gepoch / vim-surround

Surround for the Atom editor.
MIT License
52 stars 2 forks source link

Package title #4

Closed DavidLGoldberg closed 10 years ago

DavidLGoldberg commented 10 years ago

While your package is new you might want to change your package to vim-surround or vim-surround-brackets or something.

Why: Currently the apm search has no ability to search package.json keywords, description, readme, etc.

It ONLY searches the title you can find this confirmed here: https://discuss.atom.io/t/apm-search-results/11054

gepoch commented 10 years ago

Done :)

Thanks for the input!

DavidLGoldberg commented 10 years ago

Also, I've never tried, but theres' an "apm unpublish" command! Might be useful! Apm is so crazy cool right? heh.

DavidLGoldberg commented 10 years ago

Also, it should (I think) be easy to change this to vim-surround on github. Also, probably want to add the url of repo to the atom.io/packages/vim-surround.

gepoch commented 10 years ago

Yeah! I took care of the unpublish already. Sorry to the two people in the world that will never get another update.

For full completeness, the repository shall move.

I continue to be totally amazed at the quality of the tooling around Atom. It's an amazing platform to be working on.

DavidLGoldberg commented 10 years ago

➜ jumpy git:(clear_irrelevant_labels) apm upgrade Package Updates Available (1) └── vim-surround 0.1.5 -> 0.1.6

Would you like to install these updates? (yes)

Installing vim-surround@0.1.6 to /Users/dgoldberg/.atom/packages ✗ Unable to download https://www.atom.io/api/packages/vim-surround/versions/0.1.6/tarball: 400 Bad Request Repository inaccessible ➜ jumpy git:(clear_irrelevant_labels) apm update Installing modules ✓ ➜ jumpy git:(clear_irrelevant_labels) apm upgrade Package Updates Available (1) └── vim-surround 0.1.5 -> 0.1.6

Would you like to install these updates? (yes)

Installing vim-surround@0.1.6 to /Users/dgoldberg/.atom/packages ✗ Unable to download https://www.atom.io/api/packages/vim-surround/versions/0.1.6/tarball: 400 Bad Request Repository inaccessible

Actually, I'm not sure exactly why that happened, you probably know best, maybe worst comes to worse apm publish again?

Also, run "apm upgrade" on your side... are you using "atom develop vim-surround" you should.. adn then atom -d ~/github/vim-surround (read the help on atom develop)

DavidLGoldberg commented 10 years ago

I edited the previous, so you might have to refresh.

gepoch commented 10 years ago

Yeah, there seems to have been some issues in the name change. Looking into it now.

gepoch commented 10 years ago

Okay, sorted it out.

Apm didn't like the fact that I change the repo location. It was somehow looking for the old location, and couldn't find tags and such.

Basically, I moved the repo back to surround, unpublished, moved to vim-surround, republished.

Everything should be good, now. :)

gepoch commented 10 years ago

FYI https://discuss.atom.io/t/could-not-unpublish-my-package/3041/6

DavidLGoldberg commented 10 years ago

so you're on github/surround and atom.io/vim-surround (that works too)

DavidLGoldberg commented 10 years ago

Oh, I see, looks good

gepoch commented 10 years ago

Ah no. I eventually have both of them moved to vim-surround. I just basically had to destroy the entire old atom package.

It seems that once you create an atom packge project on Atom.io, it needs to be able to talk to the repository that it originated from.

gepoch commented 10 years ago

And changing the repository field in the package.json didn't seem to help either. It was a full unpublish/republish that finally fixed everything.

DavidLGoldberg commented 10 years ago

also, FYI, I noticed, I had a top level property 'jumpy' (my only package) http://atom.io/packages/jumpy (shameless plug) that I found in my 'Atom' -> 'Open Your Config'

That might be a little of the secret sauce, or it might not have anything to do with anything :)

gepoch commented 10 years ago

Haha, you buzz marketing fiend.

Doesn't look like that was the cause, though...

DavidLGoldberg commented 10 years ago

Do you still have both entries in there, just curious what the heck that thing is for heh.

gepoch commented 10 years ago

The config file?

That's for user defined config values that override the values you set in the configDefaults in your package's exports.

DavidLGoldberg commented 10 years ago

Ahh, cool.