search

geraintpalmer / DetectingDeadlockInQingNetworkSimulation

0 stars 0 forks source link

Addresses #11 #12

Closed drvinceknight closed 9 years ago

drvinceknight commented 9 years ago

Before you merge: click on each commit hash (tell me you don't know what that means) and make notes of the changes I'm suggesting and or doing (it's a good learning process).

drvinceknight commented 9 years ago

Make sure you click on the ... after each commit message when it exists before clicking on the hash.

geraintpalmer commented 9 years ago

Thank you very much!! Can I merge some commits and not others? I think one or two or your comments are incorrect (caused by my poor explanation of things)

drvinceknight commented 9 years ago

You can do but it's a bit tricky. Merge them in and then revert them git revert hash or just change them to something else (if they weren't well explained maybe fix that).

Ideally each commit could have been a PR but that would have meant me branching and couldn't be bother.

You should watch the pycon videos.

On Tue, 21 Apr 2015 16:20 Geraint Palmer notifications@github.com wrote:

Thank you very much!! Can I merge some commits and not others? I think one or two or your comments are incorrect (caused by my poor explanation of things)

— Reply to this email directly or view it on GitHub https://github.com/geraintpalmer/DetectingDeadlockInQingNetworkSimulation/pull/12#issuecomment-94837116 .