search

geraldkoh4 / pe

0 stars 0 forks source link

DG diagrams look slightly too complicated #21

Open geraldkoh4 opened 1 year ago

geraldkoh4 commented 1 year ago

image.png

I believe that some of the methods can be abstracted. As of now, the diagrams look slightly too complicated and hard to understand.

nus-pe-script commented 1 year ago

Team's Response

Each class are clearly indicate which is better for understanding

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do indeed understand that the class is clearly labelled. However, this diagram is cluttered. Each of the boxes (components I assume) should have been a diagram on its own and have an overall architecture diagram to show the overall flow. A similar diagram proposed in my group's DG received similar comments and we had to edit it.