search

geraldmwangi / GuitarMidi-LV2

A concept for guitar to midi as an lv2 plugin
Other
51 stars 0 forks source link

Input level adjustment #8

Open riban-bw opened 1 week ago

riban-bw commented 1 week ago

It may be advantageous to add an input level control that can boost / antenuate the audio input. Pitch detection seems to be dependant on optimal audio level hence this control could be useful. I also observe that lower notes are detected more readily that higher notes, apparently due to signal level so some form of filter and/or compressor may be advantageous.

It would also be advantageous to have a signal output that indicates audio input level and some form of quality and/or trigger indication.

geraldmwangi commented 1 week ago

Thanks. I'll add an attenuator for the next release

On 9 September 2024 16:34:33 CEST, riban-bw @.***> wrote:

It may be advantageous to add an input level control that can boost / antenuate the audio input. Pitch detection seems to be dependant on optimal audio level hence this control could be useful. I also observe that lower notes are detected more readily that higher notes, apparently due to signal level so some form of filter and/or compressor may be advantageous.

It would also be advantageous to have a signal output that indicates audio input level and some form of quality and/or trigger indication.

-- Reply to this email directly or view it on GitHub: https://github.com/geraldmwangi/GuitarMidi-LV2/issues/8 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

geraldmwangi commented 1 week ago

What kind if trigger indication? Something like a led that lights up when a note is detected?

On 9 September 2024 16:34:33 CEST, riban-bw @.***> wrote:

It may be advantageous to add an input level control that can boost / antenuate the audio input. Pitch detection seems to be dependant on optimal audio level hence this control could be useful. I also observe that lower notes are detected more readily that higher notes, apparently due to signal level so some form of filter and/or compressor may be advantageous.

It would also be advantageous to have a signal output that indicates audio input level and some form of quality and/or trigger indication.

-- Reply to this email directly or view it on GitHub: https://github.com/geraldmwangi/GuitarMidi-LV2/issues/8 You are receiving this because you are subscribed to this thread.

Message ID: @.***>

riban-bw commented 1 week ago

A LV2 monitor port that gives inputs level and another that shows when a note is triggered (maybe one person string or a binary flag integer with bit per string).

geraldmwangi commented 1 week ago

string indication is hard for the polyphonic case. I am working on a machine learning algo to do the string separation. When it works I'll implement the indicator. If you have expertise in ML, help is welcome :)