search

geraldneo567 / pe

0 stars 0 forks source link

No error message when no match #10

Open geraldneo567 opened 2 years ago

geraldneo567 commented 2 years ago

After typing filter byOwner/Germaine where there is no pet with owner matching Germaine, an empty list is shown rather than an error message.

image.png

soc-se-bot commented 2 years ago

Team's Response

Nice suggestion. But it does not make sense to have an error message for no search results. Google does not have error messages when there are no search results as well.

Thank you for the review though.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Firstly, when there are no search results on Google, it displays a specified error message to handle the exact scenario.

image.png

As opposed to saying "0 results found" and listing a totally blank page.

image.png

Think of the perspective of a user who is not tech savvy, unfamiliar with your app and unfamiliar with AB3 for that matter. If he/she makes such a mistake and is presented with this blank screen, would this not be quite user-unfriendly? They would have to scramble through the user guide to figure out that the "list" command allows them to go back to the original view, and if they are unable to figure this out then it appears to them as if the app has broken since nothing is displayed suddenly.

This situation can easily be handled without much effort by simply throwing an error message, for example and letting the user know what went wrong (and not displaying a blank page) rather than reusing the same message as when the command successfully completes with >= 1 results and subsequently clearing the entire view as if the "clear" command was run, or as if something major has gone wrong.

image.png